Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check expiry dates on custom certs #6051

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

threepointone
Copy link
Contributor

Fixes #5964

For wrangler dev, we don't have to check whether certificates have expired when they're provided by the user.

Fixes #5964

For `wrangler dev`, we don't have to check whether certificates have expired when they're provided by the user.
@threepointone threepointone requested a review from a team as a code owner June 15, 2024 08:08
Copy link

changeset-bot bot commented Jun 15, 2024

🦋 Changeset detected

Latest commit: 0776488

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9526664590/npm-package-wrangler-6051

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6051/npm-package-wrangler-6051

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9526664590/npm-package-wrangler-6051 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9526664590/npm-package-create-cloudflare-6051 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9526664590/npm-package-cloudflare-kv-asset-handler-6051
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9526664590/npm-package-miniflare-6051
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9526664590/npm-package-cloudflare-pages-shared-6051
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9526664590/npm-package-cloudflare-vitest-pool-workers-6051

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.60.3 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240610.0
workerd 1.20240610.1 1.20240610.1
workerd --version 1.20240610.1 2024-06-10

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin petebacondarwin merged commit 15aff8f into main Jun 15, 2024
19 checks passed
@petebacondarwin petebacondarwin deleted the no-expiry-check-on-custom-certs branch June 15, 2024 14:39
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Jun 15, 2024
Copy link

holopin-bot bot commented Jun 15, 2024

Congratulations @threepointone, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clxg86owl14650ckx2dgyrz7k

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes an open-source contribution, big or small
3 participants