Skip to content

Commit

Permalink
Don't check expiry dates on custom certs (#6051)
Browse files Browse the repository at this point in the history
Fixes #5964

For `wrangler dev`, we don't have to check whether certificates have expired when they're provided by the user.
  • Loading branch information
threepointone committed Jun 15, 2024
1 parent a699f3b commit 15aff8f
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
9 changes: 9 additions & 0 deletions .changeset/chatty-candles-smoke.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"wrangler": patch
---

Don't check expiry dates on custom certs

Fixes https://github.com/cloudflare/workers-sdk/issues/5964

For `wrangler dev`, we don't have to check whether certificates have expired when they're provided by the user.
4 changes: 1 addition & 3 deletions packages/wrangler/src/https-options.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,7 @@ export function getHttpsOptions(
"Missing Custom Certificate File at " + customHttpsCertPath
);
}
if (hasCertificateExpired(customHttpsKeyPath, customHttpsCertPath)) {
throw new UserError("Custom Certificate is invalid");
}

logger.log("Using custom certificate at ", customHttpsKeyPath);

return {
Expand Down

0 comments on commit 15aff8f

Please sign in to comment.