-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hybrid nodejs compat now supports requiring the default export of a CJS module #6039
fix: hybrid nodejs compat now supports requiring the default export of a CJS module #6039
Conversation
🦋 Changeset detectedLatest commit: 9446081 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9516952593/npm-package-wrangler-6039 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6039/npm-package-wrangler-6039 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9516952593/npm-package-wrangler-6039 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9516952593/npm-package-create-cloudflare-6039 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9516952593/npm-package-cloudflare-kv-asset-handler-6039 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9516952593/npm-package-miniflare-6039 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9516952593/npm-package-cloudflare-pages-shared-6039 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9516952593/npm-package-cloudflare-vitest-pool-workers-6039 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
contents: `export * from '${path}'`, | ||
contents: dedent` | ||
import libDefault from '${path}'; | ||
module.exports = libDefault;`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mixing ESM imports with and CommonJS exports but it seems that esbuild is happy to handle this when bundling.
Congratulations @petebacondarwin, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clxevgqu507790clblqjq70cb This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
What this PR solves / how to test
Fixes #6028
There is a change to the nodejs_hybrid_app fixture that demonstrates the problem and the fix.
Without this fix you get:
Author has addressed the following