Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hybrid nodejs compat now supports requiring the default export of a CJS module #6039

Merged

Conversation

petebacondarwin
Copy link
Contributor

What this PR solves / how to test

Fixes #6028

There is a change to the nodejs_hybrid_app fixture that demonstrates the problem and the fix.
Without this fix you get:

✘ [ERROR] service core:user:nodejs-hybrid-app: Uncaught TypeError: Stream2 is not a constructor

    at null.<anonymous> (index.js:8765:14) in src/dep.cjs
    at null.<anonymous> (index.js:19:50) in __require2
    at null.<anonymous> (index.js:8788:26)

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: bug fix
@petebacondarwin petebacondarwin requested a review from a team as a code owner June 14, 2024 13:27
Copy link

changeset-bot bot commented Jun 14, 2024

🦋 Changeset detected

Latest commit: 9446081

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9516952593/npm-package-wrangler-6039

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6039/npm-package-wrangler-6039

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9516952593/npm-package-wrangler-6039 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9516952593/npm-package-create-cloudflare-6039 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9516952593/npm-package-cloudflare-kv-asset-handler-6039
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9516952593/npm-package-miniflare-6039
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9516952593/npm-package-cloudflare-pages-shared-6039
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9516952593/npm-package-cloudflare-vitest-pool-workers-6039

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.60.3 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240610.0
workerd 1.20240610.1 1.20240610.1
workerd --version 1.20240610.1 2024-06-10

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

contents: `export * from '${path}'`,
contents: dedent`
import libDefault from '${path}';
module.exports = libDefault;`,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mixing ESM imports with and CommonJS exports but it seems that esbuild is happy to handle this when bundling.

@petebacondarwin petebacondarwin merged commit dc597a3 into main Jun 14, 2024
26 checks passed
@petebacondarwin petebacondarwin deleted the fix-default-import-on-requires-in-hybrid-nodejs-compat branch June 14, 2024 15:57
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Jun 14, 2024
Copy link

holopin-bot bot commented Jun 14, 2024

Congratulations @petebacondarwin, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clxevgqu507790clblqjq70cb

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes an open-source contribution, big or small e2e Run e2e tests on a PR
3 participants