fix: hybrid nodejs compat now supports requiring the default export o…

…f a CJS module (#6039)

Fixes [#6028](#6028)

.changeset/afraid-mails-kneel.md

@@ -0,0 +1,7 @@
+---
+"wrangler": patch
+---
+
+fix: hybrid nodejs compat now supports requiring the default export of a CJS module
+
+Fixes [#6028](https://github.com/cloudflare/workers-sdk/issues/6028)

fixtures/nodejs-hybrid-app/src/dep.cjs

@@ -0,0 +1,4 @@
+const Stream = require("stream");
+
+const s = new Stream();
+module.exports.s = s;

fixtures/nodejs-hybrid-app/src/index.ts

@@ -1,7 +1,11 @@
 // node:assert/strict is currently an unenv alias to node:assert
 // this is not very common, but happens and we need to support it
 import assert from "node:assert/strict";
+import { Stream } from "node:stream";
 import { Client } from "pg";
+import { s } from "./dep.cjs";
+
+assert(s instanceof Stream, "expected s to be an instance of Stream");
 
 assert(true, "the world is broken");
 

packages/wrangler/src/deployment-bundle/esbuild-plugins/hybrid-nodejs-compat.ts

@@ -1,5 +1,6 @@
 import { builtinModules } from "node:module";
 import nodePath from "node:path";
+import dedent from "ts-dedent";
 import { cloudflare, env, nodeless } from "unenv";
 import { getBasePath } from "../../paths";
 import type { Plugin, PluginBuild } from "esbuild";
@@ -39,7 +40,9 @@ function handleRequireCallsToNodeJSBuiltins(build: PluginBuild) {
 		{ filter: /.*/, namespace: REQUIRED_NODE_BUILT_IN_NAMESPACE },
 		({ path }) => {
 			return {
-				contents: `export * from '${path}'`,
+				contents: dedent`
+        import libDefault from '${path}';
+        module.exports = libDefault;`,
 				loader: "js",
 			};
 		}