Create Task
Maniphest T279864

Always apply HTML transformations on wikis that have discussion tools enabled by default, reducing parser cache usage
Closed, ResolvedPublic
Actions

Description

On these wikis, >90% of users will want the transformed HTML, so it makes sense to only store this HTML in the parser cache (and never the unmodified HTML), and disabled features using CSS.

See also T267404.

Details

SubjectRepoBranchLines +/-
Don't split parser cache when reply tool is enabled by defaultmediawiki/extensions/DiscussionToolsmaster+7 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Esanders created this task.Apr 11 2021, 4:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 11 2021, 4:36 PM
ppelberg subscribed.Apr 15 2021, 12:12 AM

@Esanders how – if at all – does this ticket relate to the Approaches listed in T280204?

• Esanders moved this task from Incoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.Apr 16 2021, 12:08 PM

It is "Approach #1: Editing Team removes the cache split (always add reply links), toggle CSS in output page" but only on on-by-default wikis.

gerritbot added a comment.Apr 16 2021, 12:31 PM

Change 680316 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Don't split parser cache when reply tool is enabled by default

https://gerrit.wikimedia.org/r/680316

gerritbot added a project: Patch-For-Review.Apr 16 2021, 12:31 PM
• Esanders moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.Apr 16 2021, 12:32 PM
ppelberg mentioned this in T280204: [SPIKE] Determine short-term path forward to alleviate strain on parser cache.Apr 17 2021, 1:09 AM
ppelberg added a parent task: T280599: Reduce DiscussionTools' usage of the parser cache.Apr 19 2021, 10:44 PM
• Esanders mentioned this in T280599: Reduce DiscussionTools' usage of the parser cache.Apr 20 2021, 6:20 PM
• dpifke added a project: Performance-Team.Apr 20 2021, 6:29 PM
• dpifke moved this task from Inbox, needs triage to Radar on the Performance-Team board.Apr 20 2021, 6:33 PM
• dpifke edited projects, added Performance-Team (Radar); removed Performance-Team.
Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.Apr 20 2021, 8:04 PM
gerritbot added a comment.Apr 21 2021, 8:10 PM

Change 680316 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Don't split parser cache when reply tool is enabled by default

https://gerrit.wikimedia.org/r/680316

matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.Apr 21 2021, 8:30 PM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 21 2021, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 21 2021, 9:10 PM
ppelberg closed this task as Resolved.Apr 24 2021, 12:33 AM
ppelberg claimed this task.
ppelberg added a project: Skipped QA.
ppelberg mentioned this in T287098: Ensure discussiontools markup is hidden by CSS when parser split is removed.Jul 23 2021, 6:01 PM
matmarex mentioned this in T273072: Enable DiscussionTools page transformations (DOM modification) for all users.Aug 18 2021, 6:56 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits