7.0 related small lib updates #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most of this looks good to me but the icon stuff, we already have uiHD command to extract HD stuff: https://github.com/xivapi/SaintCoinach/blob/master/SaintCoinach.Cmd/Commands/HDUiCommand.cs |
|
yeah, uiHD is for SaintCoinach.Cmd, My changes here is a universal switch for sc lib calling methods for some XIV row .NET objects like Saint.Item.Icon etc. |
Supamiu
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maybe there is no one else using sc lib but just ... create pull request here? incase there are really someone other using sc lib.
7.0 patch related fillings and add a small feature to allow lib always return high res icons.
And, Lgb and Sgb files changed a lot . Access to 'bg/ffxiv/sea_s1/twn/s1t2/level/planevent.lgb' file failed and tried to read it manually but all messy. maybe discuss it later.