-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][breakpoints] Add ultra-wide breakpoint #42860
base: next
Are you sure you want to change the base?
Conversation
Hi @siriwatknp & @brijeshb42 (sorry if tagged wrong people, just look at Git file history). I have a question regarding the Pigment CSS package which is causing this PR to fail in the Essentially, the Error:
I've tried to update the Pigment CSS package with the new Any advice on how to resolve this issue? |
Added an ultra-wide breakpoint to be used within the Material-UI . The
uw
(ultra-wide) breakpoint is set to 2560px.The intent behind this new breakpoint is to enable the
<Grid />
component to be more responsive on ultra-wide monitors. This provides a distinct layout experience for users with ultra-wide screens, different from thexl
breakpoint.The
uw
naming was chosen overxxl
to maintain consistency with the two-letter format used for other breakpoints and to clearly distinguish it from thexl
breakpoint.Note
Running
pnpm test:unit
locally on this branchbreakpoint-ultra-wide
and onnext
both return 272 failed unit tests, which seem to be related tov6.0.0
(example@mui/codemod v6.0.0 dynamic spread sx-v6 should be idempotent:
). I am assuming these changes are non-breaking and should not cause any issues. I tested these breakpoints in the playground (docs/pages/playground/index.tsx) with different window widths with the<Grid />
component:<Grid item uw={3} xl={4} md={6} xs={12}>