Compiler: unfork prettier config #30205
Open
+12,346
−12,570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
poteto
requested changes
Jul 8, 2024
There was a problem hiding this comment.
Hmm I get the desire to have consistent configs, but I'm wondering if this warrants a discussion? We've used the existing settings for a while now so there's some familiarity with how it was formatted before. Makes sense to be consistent, but styling is subjective so I think it'd be worth getting everyone's thoughts before landing this one.
Sending back to your queue though to run yarn snap:build && yarn snap --update to update the snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the prettier config to format all
.tsand.tsxfiles in the repo using the existing defaults and removing overrides.The first commit in this PR contains the config changes, the second is just the result of running
yarn prettier-all.