Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: export cjs/umd as react@17 #28944

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

vctqs1
Copy link

@vctqs1 vctqs1 commented Apr 29, 2024

Summary

Resolve: #28371

How did you test this change?

@react-sizebot
Copy link

react-sizebot commented Apr 29, 2024

Comparing: 3db98c9...412d1c9

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.99 kB 497.99 kB = 89.27 kB 89.27 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.81 kB 502.81 kB = 89.97 kB 89.97 kB
facebook-www/ReactDOM-prod.classic.js = 597.08 kB 597.08 kB = 105.33 kB 105.33 kB
facebook-www/ReactDOM-prod.modern.js = 571.42 kB 571.42 kB = 101.27 kB 101.27 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Generated by 🚫 dangerJS against 412d1c9

@vctqs1
Copy link
Author

vctqs1 commented May 21, 2024

bump

Copy link

vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 3:08am
@vctqs1 vctqs1 changed the title chore: export cjs/umd as v17 Jul 3, 2024
@vctqs1
Copy link
Author

vctqs1 commented Jul 3, 2024

@sebmarkbage I'm sorry for the inconvenience, but could you please help review this PR? I need it for an upcoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants