Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: vitest-pool-workers use env in .dev.vars #6180

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Fix: vitest-pool-workers use env in .dev.vars #6180

merged 1 commit into from
Jul 2, 2024

Conversation

Skye-31
Copy link
Contributor

@Skye-31 Skye-31 commented Jul 2, 2024

What this PR solves / how to test

#5612 added support for selecting the environment of config used, but it missed passing it to the code that reads .dev.vars.{environment}

Fixes #5641

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because:
#5612 added support for selecting the environment of config used, but it missed passing it to the code that reads `.dev.vars.{environment}`
@Skye-31 Skye-31 requested a review from a team as a code owner July 2, 2024 10:43
Copy link

changeset-bot bot commented Jul 2, 2024

🦋 Changeset detected

Latest commit: bb7a6ba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving pending CI, thanks!

Copy link
Contributor

github-actions bot commented Jul 2, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9759525158/npm-package-wrangler-6180

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6180/npm-package-wrangler-6180

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9759525158/npm-package-wrangler-6180 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9759525158/npm-package-create-cloudflare-6180 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9759525158/npm-package-cloudflare-kv-asset-handler-6180
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9759525158/npm-package-miniflare-6180
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9759525158/npm-package-cloudflare-pages-shared-6180
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9759525158/npm-package-cloudflare-vitest-pool-workers-6180

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.62.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240620.0
workerd 1.20240620.1 1.20240620.1
workerd --version 1.20240620.1 2024-06-20

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@Skye-31 Skye-31 merged commit b994604 into main Jul 2, 2024
19 checks passed
@Skye-31 Skye-31 deleted the fix-5641 branch July 2, 2024 12:42
@workers-devprod workers-devprod mentioned this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants