Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React free dev registry #6147

Merged
merged 20 commits into from
Jun 27, 2024
Merged

React free dev registry #6147

merged 20 commits into from
Jun 27, 2024

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented Jun 25, 2024

What this PR solves / how to test

Implements a react-free integration of the dev registry.

Fixes DEVX-1294

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: internal refactor
@penalosa penalosa requested a review from a team as a code owner June 25, 2024 17:09
Copy link

changeset-bot bot commented Jun 25, 2024

🦋 Changeset detected

Latest commit: 71358da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 25, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9701938221/npm-package-wrangler-6147

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6147/npm-package-wrangler-6147

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9701938221/npm-package-wrangler-6147 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9701938221/npm-package-create-cloudflare-6147 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9701938221/npm-package-cloudflare-kv-asset-handler-6147
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9701938221/npm-package-miniflare-6147
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9701938221/npm-package-cloudflare-pages-shared-6147
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9701938221/npm-package-cloudflare-vitest-pool-workers-6147

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.62.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240620.0
workerd 1.20240620.1 1.20240620.1
workerd --version 1.20240620.1 2024-06-20

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa added the e2e Run e2e tests on a PR label Jun 25, 2024
Copy link
Contributor

@RamIdeas RamIdeas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As discussed in person, we should add steps to the service-binding tests where the bound worker is modified and ensure the dev registry continues to work as expected. But that can be added in a follow-up PR since the e2e tests have been rewritten in #6077

@penalosa penalosa force-pushed the penalosa/react-free-dev-registry branch from d780e13 to b9f2c55 Compare June 27, 2024 12:41
@penalosa penalosa force-pushed the penalosa/react-free-dev-registry branch from b9f2c55 to 5ea35b7 Compare June 27, 2024 13:51
@penalosa penalosa merged commit 02dda3d into main Jun 27, 2024
21 checks passed
@penalosa penalosa deleted the penalosa/react-free-dev-registry branch June 27, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
2 participants