-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React free dev registry #6147
React free dev registry #6147
Conversation
🦋 Changeset detectedLatest commit: 71358da The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9701938221/npm-package-wrangler-6147 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6147/npm-package-wrangler-6147 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9701938221/npm-package-wrangler-6147 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9701938221/npm-package-create-cloudflare-6147 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9701938221/npm-package-cloudflare-kv-asset-handler-6147 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9701938221/npm-package-miniflare-6147 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9701938221/npm-package-cloudflare-pages-shared-6147 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9701938221/npm-package-cloudflare-vitest-pool-workers-6147 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. As discussed in person, we should add steps to the service-binding tests where the bound worker is modified and ensure the dev registry continues to work as expected. But that can be added in a follow-up PR since the e2e tests have been rewritten in #6077
d780e13
to
b9f2c55
Compare
b9f2c55
to
5ea35b7
Compare
What this PR solves / how to test
Implements a react-free integration of the dev registry.
Fixes DEVX-1294
Author has addressed the following