Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wrangler] fix: improve the getPlatformProxy configPath option ts-doc comment to clarify its behavior #6142

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Jun 25, 2024

Author has addressed the following

@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner June 25, 2024 11:34
Copy link

changeset-bot bot commented Jun 25, 2024

🦋 Changeset detected

Latest commit: ba1d0dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 25, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9661840817/npm-package-wrangler-6142

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6142/npm-package-wrangler-6142

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9661840817/npm-package-wrangler-6142 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9661840817/npm-package-create-cloudflare-6142 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9661840817/npm-package-cloudflare-kv-asset-handler-6142
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9661840817/npm-package-miniflare-6142
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9661840817/npm-package-cloudflare-pages-shared-6142
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9661840817/npm-package-cloudflare-vitest-pool-workers-6142

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.61.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240610.1
workerd 1.20240610.1 1.20240610.1
workerd --version 1.20240610.1 2024-06-10

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One NIT

packages/wrangler/src/api/integrations/platform/index.ts Outdated Show resolved Hide resolved
Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>
Co-authored-by: Somhairle MacLeòid <smacleod@cloudflare.com>
@dario-piotrowicz dario-piotrowicz merged commit 9272ef5 into main Jun 26, 2024
19 checks passed
@dario-piotrowicz dario-piotrowicz deleted the amend-configPath-tsdoc branch June 26, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants