Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ws@8 everywhere #6127

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Update ws@8 everywhere #6127

merged 3 commits into from
Jun 27, 2024

Conversation

DaniFoldi
Copy link
Contributor

What this PR solves / how to test

GHSA-3h5v-q93c-6h6q was published a few days ago, and while wrangler doesn't use ws in a production setting, still worth updating to silence the warning. Tests passed locally, here's hope they will in CI.

Fixes #[insert GH or internal issue number(s)].

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: dependency update
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because:
@DaniFoldi DaniFoldi requested a review from a team as a code owner June 22, 2024 10:21
Copy link

changeset-bot bot commented Jun 22, 2024

🦋 Changeset detected

Latest commit: 3d45242

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
miniflare Patch
wrangler Patch
@cloudflare/pages-shared Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 23, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9676170362/npm-package-wrangler-6127

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6127/npm-package-wrangler-6127

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9676170362/npm-package-wrangler-6127 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9676170362/npm-package-create-cloudflare-6127 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9676170362/npm-package-cloudflare-kv-asset-handler-6127
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9676170362/npm-package-miniflare-6127
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9676170362/npm-package-cloudflare-pages-shared-6127
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9676170362/npm-package-cloudflare-vitest-pool-workers-6127

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.62.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240620.0
workerd 1.20240620.1 1.20240620.1
workerd --version 1.20240620.1 2024-06-20

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@andyjessop andyjessop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@andyjessop andyjessop merged commit 1568c25 into cloudflare:main Jun 27, 2024
20 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Jun 27, 2024
Copy link

holopin-bot bot commented Jun 27, 2024

Congratulations @DaniFoldi, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/clxwym7wj09210cmfi0zfc2jb

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes an open-source contribution, big or small
4 participants