Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version followups - fix rollback, version view improvements #6118

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

WalshyDev
Copy link
Member

What this PR solves / how to test

Fixes rollback in interactive mode, improves the versions view command and small message changes to secret put/delete/bulk.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge) -- will be done after merge
    • Cloudflare docs PR(s):
    • Not necessary because:
@WalshyDev WalshyDev requested a review from a team as a code owner June 21, 2024 13:01
Copy link

changeset-bot bot commented Jun 21, 2024

🦋 Changeset detected

Latest commit: 09346b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 21, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9614225897/npm-package-wrangler-6118

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6118/npm-package-wrangler-6118

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9614225897/npm-package-wrangler-6118 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9614225897/npm-package-create-cloudflare-6118 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9614225897/npm-package-cloudflare-kv-asset-handler-6118
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9614225897/npm-package-miniflare-6118
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9614225897/npm-package-cloudflare-pages-shared-6118
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9614225897/npm-package-cloudflare-vitest-pool-workers-6118

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.61.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240610.1
workerd 1.20240610.1 1.20240610.1
workerd --version 1.20240610.1 2024-06-10

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@WalshyDev WalshyDev merged commit 1621992 into main Jun 21, 2024
19 checks passed
@WalshyDev WalshyDev deleted the walshy/version-followup branch June 21, 2024 14:08
startMessage: `Performing rollback`,
endMessage: "",
});
logger.log("Performing rollback...");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not a great experience. It breaks the layout of the output.

Before:

? Are you sure you want to deploy this Worker Version to 100% of traffic?
🤖 Using fallback value in non-interactive context: yes
├ Performing rollback
│

After:

? Are you sure you want to deploy this Worker Version to 100% of traffic?
🤖 Using fallback value in non-interactive context: yes
Performing rollback
│
CarmenPopoviciu added a commit that referenced this pull request Jun 21, 2024
Fixes versions e2e tests that started failing
after we merged ##6118
CarmenPopoviciu added a commit that referenced this pull request Jun 22, 2024
Fixes versions e2e tests that started failing
after we merged ##6118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants