Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r2] Allow Large Uploads in Local Wrangler #6064

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

helloimalastair
Copy link
Contributor

@helloimalastair helloimalastair commented Jun 16, 2024

What this PR solves / how to test

Fixes #5821.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: One Line change ok? Not entirely sure
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: Limits for the wrangler API aren't documented in the CLI docs atm.
@helloimalastair helloimalastair requested a review from a team as a code owner June 16, 2024 10:49
Copy link

changeset-bot bot commented Jun 16, 2024

🦋 Changeset detected

Latest commit: 3305906

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9535406652/npm-package-wrangler-6064

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6064/npm-package-wrangler-6064

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9535406652/npm-package-wrangler-6064 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9535406652/npm-package-create-cloudflare-6064 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9535406652/npm-package-cloudflare-kv-asset-handler-6064
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9535406652/npm-package-miniflare-6064
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9535406652/npm-package-cloudflare-pages-shared-6064
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9535406652/npm-package-cloudflare-vitest-pool-workers-6064

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.60.3 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240610.0
workerd 1.20240610.1 1.20240610.1
workerd --version 1.20240610.1 2024-06-10

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@threepointone
Copy link
Contributor

Thanks for the PR!

@threepointone threepointone merged commit 84e6aeb into cloudflare:main Jun 16, 2024
19 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Jun 16, 2024
Copy link

holopin-bot bot commented Jun 16, 2024

Congratulations @helloimalastair, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clxhkhfev58430cjvg29hy1m9

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@helloimalastair helloimalastair deleted the r2-local branch June 16, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes an open-source contribution, big or small
3 participants