Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quieter builds #6058

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Quieter builds #6058

merged 1 commit into from
Jun 15, 2024

Conversation

threepointone
Copy link
Contributor

@threepointone threepointone commented Jun 15, 2024

This patch cleans up warnings we were seeing when doing a full build. Specifically:

  • fixtures/remix-pages-app had a bunch of warnings about impending features that it should be upgraded to, so I did that. (tbh this one needs a full upgrade of packages, but we'll get to that later when we're upgrading across the codebase)
  • updated @microsoft/api-extractor so it didn't complain that it didn't match the typescript version (that we'd recently upgraded)
  • it also silenced a bunch of warnings when exporting types from wrangler. We'll need to fix those, but we'll do that when we work on unstable_dev etc.
  • workers-playground was complaining about the size of the bundle being generated, so I increased the limit on it
@threepointone threepointone requested a review from a team as a code owner June 15, 2024 15:02
Copy link

changeset-bot bot commented Jun 15, 2024

🦋 Changeset detected

Latest commit: 2cbdd9e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
miniflare Patch
wrangler Patch
@cloudflare/pages-shared Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 15, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9529080561/npm-package-wrangler-6058

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6058/npm-package-wrangler-6058

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9529080561/npm-package-wrangler-6058 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9529080561/npm-package-create-cloudflare-6058 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9529080561/npm-package-cloudflare-kv-asset-handler-6058
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9529080561/npm-package-miniflare-6058
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9529080561/npm-package-cloudflare-pages-shared-6058
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9529080561/npm-package-cloudflare-vitest-pool-workers-6058

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.60.3 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240610.0
workerd 1.20240610.1 1.20240610.1
workerd --version 1.20240610.1 2024-06-10

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

fixtures/remix-pages-app/app/root.tsx Outdated Show resolved Hide resolved
@threepointone threepointone force-pushed the silence-api-extractor-warnings branch from b064b2e to 14dc17a Compare June 15, 2024 15:08
This patch cleans up warnings we were seeing when doing a full build. Specifically:

- fixtures/remix-pages-app had a bunch of warnings about impending features that it should be upgraded to, so I did that. (tbh this one needs a full upgrade of packages, but we'll get to that later when we're upgrading across the codebase)
- updated `@microsoft/api-extractor` so it didn't complain that it didn't match the `typescript` version (that we'd recently upgraded)
- it also silenced a bunch of warnings when exporting types from `wrangler`. We'll need to fix those, but we'll do that when we work on unstable_dev etc.
- workers-playground was complaining about the size of the bundle being generated, so I increased the limit on it
@threepointone threepointone force-pushed the silence-api-extractor-warnings branch from 14dc17a to 2cbdd9e Compare June 15, 2024 15:22
@threepointone threepointone merged commit 31cd51f into main Jun 15, 2024
20 checks passed
@threepointone threepointone deleted the silence-api-extractor-warnings branch June 15, 2024 15:27
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Jun 15, 2024
Copy link

holopin-bot bot commented Jun 15, 2024

Congratulations @threepointone, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clxg9v42n00960cl7lee21kub

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes an open-source contribution, big or small
3 participants