Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize more deps #6050

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Normalize more deps #6050

merged 1 commit into from
Jun 18, 2024

Conversation

threepointone
Copy link
Contributor

@threepointone threepointone commented Jun 15, 2024 •
edited
Loading

This is the last of the patches that normalize dependencies across the codebase. In this batch: ws, zod , rimraf, @types/rimraf, ava, source-map, glob, cookie, @types/cookie, @microsoft/api-extractor, @types/mime, @types/yargs, devtools-protocol, @vitest/ui, strip-ansi

This patch also sorts dependencies in every package.json

There are 2 remaining after this; execa and vitest. Changing their versions seems to break the build, so those will be for the next PR.
@threepointone threepointone requested a review from a team as a code owner June 15, 2024 07:34
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 15, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 15a12cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@cloudflare/vitest-pool-workers Patch
@cloudflare/pages-shared Patch
miniflare Patch
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 15, 2024 •
edited
Loading

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9552187042/npm-package-wrangler-6050

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6050/npm-package-wrangler-6050

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9552187042/npm-package-wrangler-6050 dev path/to/script.js
Additional artifacts: 
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9552187042/npm-package-create-cloudflare-6050 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9552187042/npm-package-cloudflare-kv-asset-handler-6050
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9552187042/npm-package-miniflare-6050
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9552187042/npm-package-cloudflare-pages-shared-6050
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9552187042/npm-package-cloudflare-vitest-pool-workers-6050

Note that these links will no longer work once the GitHub Actions artifact expires.

wrangler@3.60.3 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240610.0
workerd 1.20240610.1 1.20240610.1
workerd --version 1.20240610.1 2024-06-10

Please ensure constraints are pinned, and miniflare/workerd minor versions match.
@threepointone threepointone added the e2e Run e2e tests on a PR label Jun 15, 2024
threepointone
threepointone commented Jun 15, 2024
View reviewed changes
packages/miniflare/test/setup.mjs
@@ -42,3 +43,11 @@ process.on("exit", () => {
);
throw new Error(message);
});

// https://github.com/avajs/ava/discussions/3259
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to make this change to update miniflare's ava to v6
@threepointone
Copy link
Contributor Author

threepointone commented Jun 15, 2024 •
edited
Loading

Wow, actual E2E errors on every platform? I'll have a look on monday. EDIT: fixed.
@threepointone threepointone force-pushed the normalize-more-deps branch 2 times, most recently from f453562 to 983bcbc Compare June 17, 2024 10:02
@threepointone
Normalize more deps
15a12cb 
This is the last of the patches that normalize dependencies across the codebase. In this batch: `ws`, `vitest`, `zod` , `rimraf`, `@types/rimraf`, `ava`, `source-map`, `glob`, `cookie`, `@types/cookie`, `@microsoft/api-extractor`, `@types/mime`, `@types/yargs`, `devtools-protocol`, `@vitest/ui`, `execa`, `strip-ansi`

This patch also sorts dependencies in every `package.json`
@petebacondarwin petebacondarwin merged commit a0c3327 into main Jun 18, 2024
22 checks passed
@petebacondarwin petebacondarwin deleted the normalize-more-deps branch June 18, 2024 06:50
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Jun 18, 2024
@holopin-bot Holopin Bot
Copy link

holopin-bot bot commented Jun 18, 2024

Congratulations @threepointone, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clxk1pimu14600cjn76qqaisy

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!
@workers-devprod workers-devprod mentioned this pull request Jun 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes an open-source contribution, big or small e2e Run e2e tests on a PR
3 participants
@threepointone @petebacondarwin @workers-devprod