Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize more dependencies. #6046

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Normalize more dependencies. #6046

merged 1 commit into from
Jun 15, 2024

Conversation

threepointone
Copy link
Contributor

Follow up to #6029, this normalizes some more dependencies : get-port, chalk, yargs, toucan-js, @typescript-eslint/parser, @typescript-eslint/eslint-plugin, esbuild-register, hono, glob-to-regexp, @cloudflare/workers-types

@threepointone threepointone requested review from a team as code owners June 14, 2024 18:41
Copy link

changeset-bot bot commented Jun 14, 2024

🦋 Changeset detected

Latest commit: ef96fa5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
edge-preview-authenticated-proxy Patch
playground-preview-worker Patch
workers-playground Patch
create-cloudflare Patch
turbo-r2-archive Patch
format-errors Patch
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 14, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9520940244/npm-package-wrangler-6046

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6046/npm-package-wrangler-6046

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9520940244/npm-package-wrangler-6046 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9520940244/npm-package-create-cloudflare-6046 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9520940244/npm-package-cloudflare-kv-asset-handler-6046
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9520940244/npm-package-miniflare-6046
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9520940244/npm-package-cloudflare-pages-shared-6046
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9520940244/npm-package-cloudflare-vitest-pool-workers-6046

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.60.3 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240610.0
workerd 1.20240610.1 1.20240610.1
workerd --version 1.20240610.1 2024-06-10

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Follow up toi #6029, this normalizes some more dependencies : `get-port`, `chalk`, `yargs`, `toucan-js`, `@typescript-eslint/parser`, `@typescript-eslint/eslint-plugin`, `esbuild-register`, `hono`, `glob-to-regexp, `@cloudflare/workers-types``
@threepointone
Copy link
Contributor Author

Thanks @dario-piotrowicz! But looks like I need someone from the wrangler team to stamp it :/ I'll wait, no rush.

@dario-piotrowicz
Copy link
Member

Thanks @dario-piotrowicz! But looks like I need someone from the wrangler team to stamp it :/ I'll wait, no rush.

yeah, I saw that a C3 owner was also needed so I figured I might try to help 🙂

@threepointone
Copy link
Contributor Author

Oh that's right. Thank you!

@petebacondarwin petebacondarwin added the e2e Run e2e tests on a PR label Jun 14, 2024
@petebacondarwin
Copy link
Contributor

Added the e2e label to run those tests since this has potentially wide-ranging impact.
If green we can land it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of interest, how did you know you could delete this file?
Is it that when you bumped the dep the 3.2.2 version was not longer there and the patch failed?
And then did you check that 3.3.1 has this patch applied directly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch was here because of the type failure happening in edge-preview-authenticated-proxy. That feels like the wrong fix. Instead, I marked those as ts-expect-error, and filed cloudflare/workerd#2273 so we can fix it correctly

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit nervous bumping the deps in the templates folder because these have no tests but can be used by people creating new applications with wrangler and c3.
Hopefully nothing has broken there...

@threepointone
Copy link
Contributor Author

All the changes under /templates are an update to workers-types, and seem to be passing now. Later I'm going to add /templates under workspaces as well.

@threepointone
Copy link
Contributor Author

Early next week, before we release, I'm going to do a whole bunch of testing of generated builds, so it'll be my fault if something broke here :)

@threepointone
Copy link
Contributor Author

weird error. I'll have a look on monday. thanks for the late assists!

@threepointone threepointone merged commit c643a81 into main Jun 15, 2024
31 checks passed
@threepointone threepointone deleted the normalize-deps branch June 15, 2024 02:32
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Jun 15, 2024
Copy link

holopin-bot bot commented Jun 15, 2024

Congratulations @threepointone, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clxfi5j7u06510cmghecpybzb

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes an open-source contribution, big or small e2e Run e2e tests on a PR
4 participants