Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow do migrations in environments #5995

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented Jun 7, 2024

What this PR solves / how to test

Allow Durable Object migrations to be overridable in environments. By making the migrations key inheritable, users can provide different migrations for each wrangler.toml environment.

Resolves #729

Author has addressed the following

Copy link

changeset-bot bot commented Jun 7, 2024

🦋 Changeset detected

Latest commit: e700742

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

By making the `migrations` key inheritable, users can provide different migrations
for each wrangler.toml environment.

Resolves [#729](#729)
@petebacondarwin petebacondarwin force-pushed the allow-do-migrations-in-environments branch from fd0fd45 to e700742 Compare June 7, 2024 12:47
Copy link
Contributor

github-actions bot commented Jun 7, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9417249321/npm-package-wrangler-5995

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5995/npm-package-wrangler-5995

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9417249321/npm-package-wrangler-5995 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9417249321/npm-package-create-cloudflare-5995 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9417249321/npm-package-cloudflare-kv-asset-handler-5995
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9417249321/npm-package-miniflare-5995
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9417249321/npm-package-cloudflare-pages-shared-5995
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9417249321/npm-package-cloudflare-vitest-pool-workers-5995

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.60.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240605.0
workerd 1.20240605.0 1.20240605.0
workerd --version 1.20240605.0 2024-06-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin petebacondarwin added the e2e Run e2e tests on a PR label Jun 7, 2024
@petebacondarwin petebacondarwin marked this pull request as ready for review June 7, 2024 13:10
@petebacondarwin petebacondarwin requested review from a team as code owners June 7, 2024 13:10
Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this make migrations under environments mandatory, or will it pick up the top one if we don't define it?

@petebacondarwin
Copy link
Contributor Author

Does this make migrations under environments mandatory, or will it pick up the top one if we don't define it?

To avoid a breaking change it is inheritable so it will be picked up from the top level.

@petebacondarwin petebacondarwin merged commit 374bc44 into main Jun 14, 2024
24 checks passed
@petebacondarwin petebacondarwin deleted the allow-do-migrations-in-environments branch June 14, 2024 16:36
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Jun 14, 2024
Copy link

holopin-bot bot commented Jun 14, 2024

Congratulations @petebacondarwin, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clxexizpf50430cjvazg2cnz9

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Copy link

@Scamreno Scamreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes an open-source contribution, big or small e2e Run e2e tests on a PR
4 participants