-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow do migrations in environments #5995
Conversation
🦋 Changeset detectedLatest commit: e700742 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fd0fd45
to
e700742
Compare
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9417249321/npm-package-wrangler-5995 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5995/npm-package-wrangler-5995 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9417249321/npm-package-wrangler-5995 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9417249321/npm-package-create-cloudflare-5995 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9417249321/npm-package-cloudflare-kv-asset-handler-5995 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9417249321/npm-package-miniflare-5995 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9417249321/npm-package-cloudflare-pages-shared-5995 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9417249321/npm-package-cloudflare-vitest-pool-workers-5995 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this make migrations under environments mandatory, or will it pick up the top one if we don't define it?
To avoid a breaking change it is inheritable so it will be picked up from the top level. |
Congratulations @petebacondarwin, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clxexizpf50430cjvazg2cnz9 This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
What this PR solves / how to test
Allow Durable Object migrations to be overridable in environments. By making the
migrations
key inheritable, users can provide different migrations for each wrangler.toml environment.Resolves #729
Author has addressed the following