feat(wrangler-d1): Teach wrangler d1 insights about more timePeriods

[achanda]

What this PR solves / how to test

This PR teaches wrangler d1 insights about more timePeriods. The input can now be of the form\d+[dmh]

Fixes #5048

Author has addressed the following

• Tests
  • TODO (before merge)
  • Included
  • Not necessary because:
• Changeset (Changeset guidelines)
  • TODO (before merge)
  • Included
  • Not necessary because:
• Public documentation
  • TODO (before merge)
  • Cloudflare docs PR(s): https://github.com/cloudflare/cloudflare-docs/pull/...
  • Not necessary because:

[changeset-bot]

🦋 Changeset detected

Latest commit: 6a85760

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
wrangler	Patch
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9466800360/npm-package-wrangler-5307

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5307/npm-package-wrangler-5307

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9466800360/npm-package-wrangler-5307 dev path/to/script.js

Additional artifacts:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9466800360/npm-package-create-cloudflare-5307 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9466800360/npm-package-cloudflare-kv-asset-handler-5307

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9466800360/npm-package-miniflare-5307

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9466800360/npm-package-cloudflare-pages-shared-5307

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9466800360/npm-package-cloudflare-vitest-pool-workers-5307

Note that these links will no longer work once the GitHub Actions artifact expires.

---

wrangler@3.60.1 includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	workspace:*	3.20240605.0
workerd	1.20240605.0	1.20240605.0
workerd --version	1.20240605.0	2024-06-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 71.97%. Comparing base (2789f26) to head (9ca0cf7).
Report is 229 commits behind head on main.

❗ Current head 9ca0cf7 differs from pull request most recent head 6a85760

Please upload reports for the commit 6a85760 to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5307      +/-   ##
==========================================
- Coverage   72.44%   71.97%   -0.48%     
==========================================
  Files         331      313      -18     
  Lines       17298    16260    -1038     
  Branches     4422     4165     -257     
==========================================
- Hits        12532    11703     -829     
+ Misses       4766     4557     -209     

Files	Coverage Δ
packages/wrangler/src/d1/insights.ts	12.69% <0.00%> (-6.35%)	⬇️

... and 115 files with indirect coverage changes

[rozenmd]

Don't worry about tests/docs in this PR - we will start documenting this command soon, but have a pretty large refactor planned.

[achanda]

Thanks @rozenmd all done now

[RamIdeas]

LGTM I'm sure the existing behaviour of 1d, 7d or 31d is tested and continues to work with these changes but could you add some tests for other periods please?

Just saw @rozenmd's comment – is this PR still relevant? Had the refactor landed and is this ready to land too?

[rozenmd]

@RamIdeas I've added tests - the refactor hasn't happened yet, but this would still be useful in the meantime