Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 BUG: account_id is not passed to the /zones endpoint #4944

Closed
ichernetsky-cf opened this issue Feb 7, 2024 · 1 comment · Fixed by #6164 or #6153
Closed

🐛 BUG: account_id is not passed to the /zones endpoint #4944

ichernetsky-cf opened this issue Feb 7, 2024 · 1 comment · Fixed by #6164 or #6153
Labels
bug Something that isn't working

Comments

@ichernetsky-cf
Copy link
Contributor

Which Cloudflare product(s) does this pertain to?

Other

What version(s) of the tool(s) are you using?

Latest Wrangler

What version of Node are you using?

No response

What operating system and version are you using?

Linux

Describe the Bug

Observed behavior

Wrangler gets the error below when deploying a Worker.

Listing zones across more than 500 accounts is currently not allowed, please apply the 'account.id' filter

Expected behavior

As the error message suggests, gertZoneIdFromHost should pass account_id to the /zones endpoint.

Please provide a link to a minimal reproduction

No response

Please provide any relevant error logs

No response
@ichernetsky-cf ichernetsky-cf added the bug Something that isn't working label Feb 7, 2024
@taylorlee
Copy link
Contributor

The issue is here. We need to add 'account.id' to URLSearchParams, which presumably means passing the account down through all the calls above getZoneIdFromHost.
@ichernetsky-cf ichernetsky-cf changed the title 🐛 BUG: Mar 29, 2024
threepointone added a commit that referenced this issue Jun 28, 2024
@threepointone
fix: use account id for listing zones
d85fecd 
Fixes #4944

Trying. to fetch `/zones` fails when it spans more than 500 zones. The fix to use an account id when doing so. This patch passes the account id to the zones call, threading it through all the functions that require it.
@threepointone threepointone mentioned this issue Jun 28, 2024
Merged
12 tasks
threepointone added a commit that referenced this issue Jun 28, 2024
@threepointone
fix: use account id for listing zones
3dafbf4 
Fixes #4944

Trying. to fetch `/zones` fails when it spans more than 500 zones. The fix to use an account id when doing so. This patch passes the account id to the zones call, threading it through all the functions that require it.
threepointone added a commit that referenced this issue Jun 28, 2024
@threepointone
fix: use account id for listing zones
8c5b227 
Fixes #4944

Trying. to fetch `/zones` fails when it spans more than 500 zones. The fix to use an account id when doing so. This patch passes the account id to the zones call, threading it through all the functions that require it.
threepointone added a commit that referenced this issue Jun 28, 2024
@threepointone
fix: use account id for listing zones
c73dc47 
Fixes #4944

Trying. to fetch `/zones` fails when it spans more than 500 zones. The fix to use an account id when doing so. This patch passes the account id to the zones call, threading it through all the functions that require it.
threepointone added a commit that referenced this issue Jun 28, 2024
@threepointone
fix: use account id for listing zones
1840b9d 
Fixes #4944

Trying. to fetch `/zones` fails when it spans more than 500 zones. The fix to use an account id when doing so. This patch passes the account id to the zones call, threading it through all the functions that require it.
threepointone added a commit that referenced this issue Jun 28, 2024
@threepointone
fix: use account id for listing zones
43be6bd 
Fixes #4944

Trying. to fetch `/zones` fails when it spans more than 500 zones. The fix to use an account id when doing so. This patch passes the account id to the zones call, threading it through all the functions that require it.
threepointone added a commit that referenced this issue Jun 28, 2024
@threepointone
fix: use account id for listing zones
61d6424 
Fixes #4944

Trying. to fetch `/zones` fails when it spans more than 500 zones. The fix to use an account id when doing so. This patch passes the account id to the zones call, threading it through all the functions that require it.
threepointone added a commit that referenced this issue Jun 28, 2024
@threepointone
fix: use account id for listing zones
a1d81c1 
Fixes #4944

Trying. to fetch `/zones` fails when it spans more than 500 zones. The fix to use an account id when doing so. This patch passes the account id to the zones call, threading it through all the functions that require it.
threepointone added a commit that referenced this issue Jun 28, 2024
@threepointone
fix: use account id for listing zones
6066a3d 
Fixes #4944

Trying. to fetch `/zones` fails when it spans more than 500 zones. The fix to use an account id when doing so. This patch passes the account id to the zones call, threading it through all the functions that require it.
threepointone added a commit that referenced this issue Jun 29, 2024
@threepointone
fix: use account id for listing zones
7836571 
Fixes #4944

Trying. to fetch `/zones` fails when it spans more than 500 zones. The fix to use an account id when doing so. This patch passes the account id to the zones call, threading it through all the functions that require it.
threepointone added a commit that referenced this issue Jun 30, 2024
@threepointone
fix: use account id for listing zones
cdcb94e 
Fixes #4944

Trying. to fetch `/zones` fails when it spans more than 500 zones. The fix to use an account id when doing so. This patch passes the account id to the zones call, threading it through all the functions that require it.
@workers-devprod workers-devprod mentioned this issue Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that isn't working
2 participants
@taylorlee @ichernetsky-cf