Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to admin user's locale when sending emails #6919

Open
wants to merge 12 commits into
base: trunk
Choose a base branch
from

Conversation

at-benni
Copy link

@at-benni at-benni commented Jun 27, 2024

Description:

This patch uses the locale of a user associated with the admin_email and falls back to the site language if there is no user associated with this email address, when sending notifications to the administrator.

What issue does this solve?

  1. Currently when a new user is registered the email notification to the admin is sent in the site locale, this patch tries to figure out which language the admin understands and sends the notification is that language.
  2. Currently when a user changes his password, the email notification to the admin is sent in whatever locale the user, who is changing his password, uses. This patch also tries to figure out which language the admin understands and sends the notification is that language.

Trac ticket:

https://core.trac.wordpress.org/ticket/61518


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented Jun 27, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @benniledl@chat.wordpress.org.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props benniledl, swissspidy, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

at-benni and others added 3 commits June 27, 2024 13:22
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Co-authored-by: Pascal Birchler <pascal.birchler@gmail.com>
@swissspidy
Copy link
Member

@at-benni I just pushed some changes to your branch to also update wp_notify_postauthor() and wp_notify_moderator to do the same thing. They're a bit more complex as they loop through a bunch of emails, but they would also benefit from switching to the correct locale per recipient.

We might want to do a single restore_current_locale() instead of doing restore_previous_locale() in a loop, for performance reasons.

In addition to manual testing, this change would benefit from some unit tests. At least wp_new_user_notification has some test coverage already, so we can start there.

@swissspidy swissspidy changed the title switch locale to admin locale Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants