-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add role attribute to improve accessibility #6640
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @cyrusrtcamp@Cyruss-MacBook-Air.local, @CyrusThapa. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Triggered at Tools > Export Personal Data > Download personal data
Reproduced when a plugin install fails.
Reproduced when errors occur during credentials request
Added some additional instances I found while reviewing this. Please see the comments on the ticket, as well; this is going to need some testing instructions. Thank you! |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
In r58455 |
Fixes : ticket/47111
Summary
Add role as alert on containers showing any type of dynamically added notifications error/success/informational notice (specifically on javascript files).
Testing Instructions
src/js/_enqueues/admin/privacy-tools.js
:src/js/_enqueues/admin/user-profile.js
:src/js/_enqueues/lib/ajax-response.js
:src/js/_enqueues/wp/customize/widgets.js
:src/js/_enqueues/wp/updates.js
:src/js/_enqueues/wp/widgets/custom-html.js
:src/js/_enqueues/wp/widgets/media.js
: