Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore case if matching post type archive slugs #5591

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

hirasso
Copy link

@hirasso hirasso commented Oct 30, 2023

Matches the archive slug of custom post type archives case-insensitive, so that existing pages with the same slug don't take precedence.

The Problem

  • Have a page "Projects" with a slug of /projects/
  • Have a custom post type with an archive slug of /projects/
  • Visit /Projects/ in your frontend (with a capital P)
  • Observe how WordPress resolves to the single page instead of the archive page

Proposed Solution

Make the rewrite rule for post type archives case-insensitive using the inline modifier (?i) as described here.

Trac ticket: https://core.trac.wordpress.org/ticket/59766#ticket


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant