Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

add system font #573

Closed

Conversation

LittleBigThing
Copy link
Contributor

Adding a system font as an alternative for web fonts, example solution for #572.

adding a system font as an alternative for web fonts
theme.json Outdated Show resolved Hide resolved
@MaggieCabrera
Copy link
Collaborator

I think you mentioned this idea in #175 and in the context of the design this theme has, I suggest we include two stacks instead of just one. Let's include a serif and a sans-serif one in case people want to play with those.

What do you think @beafialho, @richtabor ?

@LittleBigThing
Copy link
Contributor Author

I think that would be a great addition to the theme. :-)

I was only thinking about if adding system fonts or font stacks could clash with the Font Library in any way in the future. See a discussion starting here. So I just mention it here. :-)

@MaggieCabrera
Copy link
Collaborator

I think that would be a great addition to the theme. :-)

I was only thinking about if adding system fonts or font stacks could clash with the Font Library in any way in the future. See a discussion starting here. So I just mention it here. :-)

I don't think it will be, most of the additions and features made to the editor are made with backwards compatibility in mind, so they won't implement something that breaks every other block theme that comes before the feature.

@matiasbenedetto can you confirm that this won't be the case?

@matiasbenedetto
Copy link

I don't think it will be, most of the additions and features made to the editor are made with backwards compatibility in mind, so they won't implement something that breaks every other block theme that comes before the feature.
@matiasbenedetto can you confirm that this won't be the case?

Exactly, there won't be any compatibility issues. Themes can add as many fonts as desired. Font Library doesn't change that.

keep slug aligned with font name
@LittleBigThing
Copy link
Contributor Author

See #590 and #591 as well as examples. :-)

@MaggieCabrera
Copy link
Collaborator

Closed in favor of #667, thanks for starting this one!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
3 participants