Skip to content
This repository has been archived by the owner on Dec 1, 2019. It is now read-only.

Selecting a Background Color preset for the Group block should automatically change the text color #964

Closed
YanCol opened this issue Nov 6, 2019 · 1 comment · Fixed by #995
Closed

Selecting a Background Color preset for the Group block should automatically change the text color #964

YanCol opened this issue Nov 6, 2019 · 1 comment · Fixed by #995

Comments

@YanCol
Copy link
Contributor

YanCol commented Nov 6, 2019

Some blocks don't have text color settings (Quote, List, Table...). If the user adds one of these blocks inside a group and selects the Primary, Accent or Secondary Color as the Background Color, the text is unreadable (and not AA compliant). It also doesn't work with custom colors.

Like Twenty Nineteen, Twenty Twenty should at least define the text color in accordance with the background color presets.

Group without Background Color Group with Primary Background Color
no-background background
aristath added a commit to aristath/twentytwenty that referenced this issue Nov 9, 2019
@aristath
Add extra selectors for WordPress#964
3d29fa3
@aristath aristath mentioned this issue Nov 9, 2019
Merged
pattonwebz pushed a commit that referenced this issue Nov 10, 2019
@aristath @pattonwebz
Ensure blocks without text color settings still adjust based on backg…
9874350 
…round changes

* Add extra selectors for #964

* PHPCS: Remove extra space
@pattonwebz
Copy link
Member

Hey @yannickiki I merged some code which I think resolves this as best as we can right now. If other issues are noted could we report them via trac so we can work on them after release. Thank you!
@allancole allancole mentioned this issue Nov 11, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
2 participants
@pattonwebz @YanCol