Align naming modals #62788
Merged
Align naming modals #62788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jasmussen
approved these changes
Jun 24, 2024
|
Size Change: -71 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
It seems that when the modal mounts, the focus goes to the first element. This caused the E2E test where the Tab key is pressed to move focus to the Name field to no longer pass. I fixed it so that it doesn't depend on the number of Tab key presses. |
|
I'm getting this for the block rename modal. This should match the others, correct?
|
|
I was mostly focussed on the modal size and auto-focussing the input in this PR. But yes, there's probably a case that the input format should be the same across. I've made a note to circle back! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Apply consistent design and behavior to naming modals in the site editor. Specifically:
sizeoptions forModal(most commonlysmall).Why?
Consistency is good. Some modals (e.g. renaming a block) already exhibit these features.
Testing Instructions
In the following flows, renaming should invoke a modal with a specific
size, and the name input should be auto-focussed:🗒️ In these scenarios all action modals will receive the given props. There may be a better way to do this, but for now it could be okay given renaming is the only action that invokes a modal.