Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Remove inexistent link from the documentation. #62624

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Fix: Remove inexistent link from the documentation. #62624

merged 1 commit into from
Jun 18, 2024

Conversation

jorgefilipecosta
Copy link
Member

The section /docs/how-to-guides/block-tutorial/introducing-attributes-and-editable-fields.md was removed, and this tutorial is not available anymore. This PR returns a link to the section that is invalid and does not exist.
@jorgefilipecosta jorgefilipecosta added the [Type] Developer Documentation Documentation for developers label Jun 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 17, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org>
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
@github-actions GitHub Actions
Copy link

Flaky tests detected in 5d66232.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9548035372
📝 Reported issues:
ellatrix
ellatrix reviewed Jun 17, 2024
View reviewed changes
docs/reference-guides/block-api/block-edit-save.md
@@ -188,7 +188,7 @@ When saving your block, you want to save the attributes in the same format speci

## Examples

Here are a couple examples of using attributes, edit, and save all together. For a full working example, see the [Introducing Attributes and Editable Fields](/docs/how-to-guides/block-tutorial/introducing-attributes-and-editable-fields.md) section of the Block Tutorial.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to it?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That section was removed here #57120 but we missed the removal of this link. The idea according to that PR was that Building your first block tutorial would be a good replacement for that section. But in this context of a block API reference linking to the build your first block tutorial is not very useful.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on that PR, it a bit weird to remove these pages and break links on the web.
@jorgefilipecosta jorgefilipecosta merged commit b43a433 into trunk Jun 18, 2024
72 checks passed
@jorgefilipecosta jorgefilipecosta deleted the fux/remove-unexisting-link-from-the-documentation branch June 18, 2024 08:58
@github-actions github-actions bot added this to the Gutenberg 18.7 milestone Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
2 participants
@jorgefilipecosta @ellatrix