Components: replace TabPanel with Tabs in inline color picker
#57292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 tasks
|
Size Change: +69 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in eed87b9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7282912389
|
chad1008
force-pushed
the
tabs-format-library
branch
2 times, most recently
from
9c4d971
to
eed87b9
Compare
chad1008
force-pushed
the
tabs-format-library
branch
from
eed87b9
to
e4862fd
Compare
chad1008
added
[Package] Components
ciampo
added
[Package] Format library
ciampo
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Left a comment, but otherwise code changes LGTM, and tests well as per instructions.
Regarding the style override, that rule is such a wide rule that I'd be tempted to assume that it wasn't meant to target the tabs. Let's wait for folks from @WordPress/gutenberg-design to chime in, but I'd be tempted to keep this PR as-is, so that we ensure better consistency across all tabbed interfaces in the editor.
|
This seems fine to me. The horizontal padding seems to be identical (12px), and the vertical padding rarely comes into play since tabs have a static height. |
|
Before and after look pretty close to me:
If anything, the after has better alignment between text and content, so that's good. |
|
THank you for the feedback, Jay and Joen! @chad1008 , feel free to merge after addressing all pending feedback |
|
Thank you all for the feedback! I've applied the recommended style cleanups and will merge once CI passes its final run! |
chad1008
force-pushed
the
tabs-format-library
branch
from
04e543b
to
415e971
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Replaces the legacy TabPanel component with the new Tabs component.
Why?
Part of the work outlined in #52997
How?
TabPanelis replaced byTabsand its sub-components.Other Stuff
This change does cause a small shift in the width of the tabs. There is a style override that no longer applies after this change because we're not rendering a
Button, and therefore the tabs do not have the.components-buttonclass associated with them.My assumption is that we'd like to keep the buttons on these tabs consistent with the previous styling. Would it be best to do that by
button[role=tab](I'm not sure if this would have unintended side effects elsewhere)cc'ing @WordPress/gutenberg-design for input. (this isn't an urgent ping, I'll be afk for the holidays coming up, but I'll circle back to this PR in the new year).
Testing Instructions
trunk(pending an answer to the padding question above)Testing Instructions for Keyboard