Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#45369 closed defect (bug) (fixed)

Twenty Nineteen: Columns Block doesn't stack up properly on iPads

Reported by: igielskv's profile igielskv Owned by: allancole's profile allancole
Milestone: 5.0.2 Priority: normal
Severity: normal Version: 5.0
Component: Bundled Theme Keywords: fixed-5.0
Focuses: Cc:

Description

Hi there, I have just tested Default behavior of Columns Block in WordPress 5.0-beta5-43907 running Twenty Nineteen theme. I think Columns do not stack up properly at least on iPads 9.7" display width, viz. attached picture below. There is an extra indent for 2nd column, which I don't think should be an intentional behavior. There's no other extra indent for 3rd column, it's aligned with one indent of the 2nd column already. I tried two different iPads one with IOS 12 one still with IOS 11, it's same on both of them. (But on smaller displays like iPhones, it's ok.)

Attachments (1)

IMG_AB15C3A0645B-1.jpeg​ (316.9 KB) - added by igielskv 6 years ago.
iPad's Screenshot showing extra indent for 2nd column of Columns Block

Download all attachments as: .zip

Change History (10)

@igielskv
6 years ago

iPad's Screenshot showing extra indent for 2nd column of Columns Block

#1 @kjellr
6 years ago

  • Component changed from Formatting to Bundled Theme
  • Summary changed from Columns Block doesn't stack up properly on iPads to Twenty Nineteen: Columns Block doesn't stack up properly on iPads

Hi @igielskv! Thanks for the report. This should be fixed once this patch gets merged in:

https://core.trac.wordpress.org/attachment/ticket/45424/45424.5.patch

More details are available in this GitHub thread:

​https://github.com/WordPress/twentynineteen/pull/674

#2 @matveb
6 years ago

  • Milestone changed from Awaiting Review to 5.0.1

This should make it in for the next minor release.

#3 @pento
6 years ago

  • Milestone changed from 5.0.1 to 5.0.2

This ticket was mentioned in ​Slack in #core-themes by kjell. ​View the logs.
6 years ago

#5 @allancole
6 years ago

  • Owner set to allancole
  • Resolution set to fixed
  • Status changed from new to closed

In 44189:

Updating Twenty Nineteen, the new default theme for 2019.

This update changes the following:

Props joen, kjellr.

Fixes #45369.

See #45424.

#6 @desrosj
6 years ago

  • Keywords fixed-5.0 added

Reopening and marking fixed-5.0 so that this can be properly merged into trunk.

#7 @SergeyBiryukov
6 years ago

  • Keywords needs-patch removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

This ticket was mentioned in ​Slack in #core-themes by allancole. ​View the logs.
6 years ago

#9 @desrosj
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 44300:

Updating Twenty Nineteen, the new default theme for 2019.

This update changes the following:

Props joen, kjellr, allancole.

Fixes #45369.

Merges [44189] into trunk.

See #45424.

Note: See TracTickets for help on using tickets.