WordPress.org

Resolved Giorgio25b
(@giorgio25b)

2 years, 8 months ago
On this page, mobile view only, the modal window is supposed to close when clicking on the contact us link.
But it does not trigger the close, it does link to the section, but unless you close the modal window manually you can’t get there.

This was an issue of past for several other themes, including Twenty Twenty, see ticket and patch here:

Patch on Github

Ticket on Trac

Hope this helps and it gets fixed.
- This topic was modified 2 years, 8 months ago by Giorgio25b. Reason: wrong project link
The page I need help with: [log in to see the link]

Viewing 5 replies - 1 through 5 (of 5 total)

Eduard
(@cteduard)

2 years, 8 months ago

Hello @giorgio25b

On what device exactly are you experiencing this issue? I have just tested this on my iPhone and the modal closes successfully for me.

Thanks

Thread Starter Giorgio25b
(@giorgio25b)

2 years, 8 months ago

@cteduard I just updated the ticket, my bad, I used the wrong dev link, this is the correct one:

https://dev.fathomscientific.ca/

Same issue as describe above. Thanks

Eduard
(@cteduard)

2 years, 8 months ago

Hey @giorgio25b

I have found the culprit. It is the https://dev.fathomscientific.ca/wp-content/themes/blocksy-child/js/app.js file that you’ve added to the child theme.

Disabling this JS file from loading seems to make everything work correctly.

I have taken a quick look at it and it seems that it contains code related to smooth scrolling. I suggest taking a look at your implementation, as you’ve probably missed something and this is the culprit.

Hope this helps.

Thanks.

Thread Starter Giorgio25b
(@giorgio25b)

2 years, 8 months ago

Thanks @cteduard you are right and I have to apologize for pinning the error on Blocksy while it was clearly my fault.
I just assumed it was a similar issue I had in the past with the TwentyTwenty theme and I did not do my due diligence checking what the problem really was.

Many thanks! This framework is just awesome.

Eduard
(@cteduard)

2 years, 8 months ago

Hey @giorgio25b

No need to apologise. 🙂 Glad we’re on the right track now.

Have a great week!

Viewing 5 replies - 1 through 5 (of 5 total)

The topic ‘Mobile Menu doesn’t close modal window when anchor links are used’ is closed to new replies.

In: Themes and Templates
5 replies
2 participants
Last reply from: Eduard
Last activity: 2 years, 8 months ago
Status: resolved