• Nick

    (@nickchomey)


    After the dev fixed some reported bugs, the plugin worked again. Hard to say how this translates into website speed, but my server is shown to be considerably faster than the average server.

    • This topic was modified 2 years, 9 months ago by Nick.
Viewing 9 replies - 1 through 9 (of 9 total)
  • Plugin Author kohashi

    (@kohashi)

    Could you post the error messages? What version of WP / mysql / php are you running?

    Thread Starter Nick

    (@nickchomey)

    WP 5.8.1, mariadb 10.5.12, php 7.4.22, OpenLiteSpeed server

    I get these 5 errors when I load the WP Performance Tester page. I dont want to run it again because it was just a seemingly infinite list. They happen even in troubleshooting mode with everything except this plugin disabled.

    Notice	wp_enqueue_script was called incorrectly. Scripts and styles should not be registered or enqueued until the wp_enqueue_scripts, admin_enqueue_scripts, or login_enqueue_scripts hooks. This notice was triggered by the chart-js handle. Please see Debugging in WordPress for more information. (This message was added in version 3.3.0.)	1	
    wp-includes/functions.php:5663
    _wp_scripts_maybe_doing_it_wrong()
    wp-includes/functions.wp-scripts.php:347
    wp_enqueue_script()
    wp-content/plugins/wpperformancetester/WPPerformanceTester_Plugin.php:350
    WPPerformanceTester_Plugin->addActionsAndFilters()
    wp-content/plugins/wpperformancetester/wp-performance-tester_init.php:42
    WPPerformanceTester_init()
    wp-content/plugins/wpperformancetester/wp-performance-tester.php:85
    Plugin: wpperformancetester
    
    Notice	wp_enqueue_script was called incorrectly. Scripts and styles should not be registered or enqueued until the wp_enqueue_scripts, admin_enqueue_scripts, or login_enqueue_scripts hooks. This notice was triggered by the jquery handle. Please see Debugging in WordPress for more information. (This message was added in version 3.3.0.)	1	
    wp-includes/functions.php:5663
    _wp_scripts_maybe_doing_it_wrong()
    wp-includes/functions.wp-scripts.php:347
    wp_enqueue_script()
    wp-content/plugins/wpperformancetester/WPPerformanceTester_Plugin.php:351
    WPPerformanceTester_Plugin->addActionsAndFilters()
    wp-content/plugins/wpperformancetester/wp-performance-tester_init.php:42
    WPPerformanceTester_init()
    wp-content/plugins/wpperformancetester/wp-performance-tester.php:85
    Plugin: wpperformancetester
    
    Notice	wp_enqueue_style was called incorrectly. Scripts and styles should not be registered or enqueued until the wp_enqueue_scripts, admin_enqueue_scripts, or login_enqueue_scripts hooks. This notice was triggered by the wppt-style handle. Please see Debugging in WordPress for more information. (This message was added in version 3.3.0.)	1	
    wp-includes/functions.php:5663
    _wp_scripts_maybe_doing_it_wrong()
    wp-includes/functions.wp-styles.php:174
    wp_enqueue_style()
    wp-content/plugins/wpperformancetester/WPPerformanceTester_Plugin.php:352
    WPPerformanceTester_Plugin->addActionsAndFilters()
    wp-content/plugins/wpperformancetester/wp-performance-tester_init.php:42
    WPPerformanceTester_init()
    wp-content/plugins/wpperformancetester/wp-performance-tester.php:85
    Plugin: wpperformancetester
    
    Notice	wp_enqueue_style was called incorrectly. Scripts and styles should not be registered or enqueued until the wp_enqueue_scripts, admin_enqueue_scripts, or login_enqueue_scripts hooks. This notice was triggered by the simptip-style handle. Please see Debugging in WordPress for more information. (This message was added in version 3.3.0.)	1	
    wp-includes/functions.php:5663
    _wp_scripts_maybe_doing_it_wrong()
    wp-includes/functions.wp-styles.php:174
    wp_enqueue_style()
    wp-content/plugins/wpperformancetester/WPPerformanceTester_Plugin.php:353
    WPPerformanceTester_Plugin->addActionsAndFilters()
    wp-content/plugins/wpperformancetester/wp-performance-tester_init.php:42
    WPPerformanceTester_init()
    wp-content/plugins/wpperformancetester/wp-performance-tester.php:85
    Plugin: wpperformancetester
    
    Deprecated	Invalid characters passed for attempted conversion, these have been ignored	99,967	
    wp-content/plugins/wpperformancetester/benchmark.php:69
    bindec()
    wp-content/plugins/wpperformancetester/benchmark.php:69
    test_math()
    wp-content/plugins/wpperformancetester/benchmark.php:45
    test_benchmark()
    wp-content/plugins/wpperformancetester/WPPerformanceTester_Plugin.php:65
    WPPerformanceTester_Plugin->settingsPage()
    wp-includes/class-wp-hook.php:303
    do_action('tools_page_WPPerformanceTester_PluginSettings')
    wp-admin/admin.php:259
    Plugin: wpperformancetester
    • This reply was modified 2 years, 9 months ago by Nick.
    • This reply was modified 2 years, 9 months ago by James Huff.
    Thread Starter Nick

    (@nickchomey)

    Looks like this was reported nearly 3 years ago with a fix submitted and never integrated… same with 2 other pull requests and various reported issues ignored… Is this plugin abandoned or no?

    https://wordpress.org/support/topic/php-warnings-71/

    Thread Starter Nick

    (@nickchomey)

    I decided to run it again with Query Monitor enabled to intercept the errors. It seemed to work, but returned the previous notices along with the following notice (to be clear, that’s 99,967, which is, in essence, infinite). This probably accounts for my server’s poor results in the Math test, while having exceptional results in the rest of the tests.

    Deprecated	Invalid characters passed for attempted conversion, these have been ignored	99,967	
    wp-content/plugins/wpperformancetester/benchmark.php:69
    bindec()
    wp-content/plugins/wpperformancetester/benchmark.php:69
    test_math()
    wp-content/plugins/wpperformancetester/benchmark.php:45
    test_benchmark()
    wp-content/plugins/wpperformancetester/WPPerformanceTester_Plugin.php:65
    WPPerformanceTester_Plugin->settingsPage()
    wp-includes/class-wp-hook.php:303
    do_action('tools_page_WPPerformanceTester_PluginSettings')
    wp-admin/admin.php:259
    Plugin: wpperformancetester
    Plugin Author kohashi

    (@kohashi)

    Thank you for the report. I’ve updated the code on github merging in that pull request and going through all the old pull requests there. I’ve also applied the changes the plugin here on .org.

    Appreciate you giving me the push and reminder to fix these things.

    If you wouldn’t mind giving it another try to confirm it’s working again it would be appreciated.

    Thread Starter Nick

    (@nickchomey)

    Thanks for the attentiveness!

    The original errors are gone now, but the 100,000 errors still happen, related to the files and lines mentioned above.

    You only see them if you have query monitor activated or define( ‘WP_DEBUG_DISPLAY’, true); set in wp-config.

    If you have query monitor on, it intercepts them from debug_display, and my math score slows from 0.3 to 1 second. If I have query monitor off, it literally prints all 100k errors on the screen and I stopped waiting for it to load after a minute or two.

    I would imagine you could replicate the same if you use one or both of those options.

    Thread Starter Nick

    (@nickchomey)

    The problem is that you’re using bindec, which converts a binary to decimal, instead of decbin. If you change that, it works without errors. https://www.php.net/manual/en/function.bindec.php

    I suppose this somewhat taints all previous results, since it would never have worked properly. But, I suppose the purpose is to compare servers, so they’d all have suffered from the same issue.

    Plugin Author kohashi

    (@kohashi)

    This seems to be a 7.4 issue (the deprecated warning), older versions would have all worked the same.

    I won’t be pushing out that change quite yet, there are a few bigger issues I want to solve. This would be a breaking change in terms of comparing performance between results. So I want to group all those together and do it at once rather than have versions that have changes that the results will be meaningless against all old ones and new ones shortly after.

    Hope that makes sense.

    Thread Starter Nick

    (@nickchomey)

    Ok, that makes sense to keep it as apples to apples for now, and then switch it all at once. Its only one of many math tests, so doesn’t affect the overall score much.

    I tried implementing the change recommended in this comprehensive article but it didnt work. Hopefully you can incorporate something to that effect in the changes as well.

    FYI, I’ve changed my review. Thanks for your support and I look forward to the upcoming changes.

    (https://www.webwhim.co.uk/how-to-select-a-wordpress-hosting-provider/)

    We have modified original Benchmark.php file – an open-source script which was copied and changed for WP Perfomance Tester by Kevin Ohashi. We have replaced the original string with the:
    $query = “SELECT BENCHMARK(10000000, AES_ENCRYPT(‘hello’, RAND()));”;
    We increased the number of tests tenfold and added the RAND() function. Our goal was to get Benchmark.php to perform a measurement as similar as possible to that of the WPPerformance Tester plugin. The only difference between the two tests now is the functions AES _ENCRYPT() and ENCODE().

Viewing 9 replies - 1 through 9 (of 9 total)
  • The topic ‘Works well, my server is exceptionally fast, as expected’ is closed to new replies.