Changeset 633570

Timestamp:

12/03/2012 04:47:20 PM (12 years ago)

Author:

jbrinley

Message:

add field for link target

Location:

widget-builder/trunk

Files:

• classes/widget-builder.php (modified) (3 diffs)
• views/metabox_link.php (modified) (1 diff)
• views/widget.php (modified) (1 diff)

widget-builder/trunk/classes/widget-builder.php

@@ -204 +204 @@
                         'link_url' => get_post_meta($widget->ID, '_' . Tribe_Widget_Builder::TOKEN . '_link_url', true),
                         'link_text' => get_post_meta($widget->ID, '_' . Tribe_Widget_Builder::TOKEN . '_link_text', true),
+
                         'widget_description' => get_post_meta($widget->ID, '_' . Tribe_Widget_Builder::TOKEN . '_widget_description', true),
                         'dashboard' => get_post_meta($widget->ID, '_' . Tribe_Widget_Builder::TOKEN . '_dashboard', true),
@@ -352 +353 @@
 
             global $post_id;
-
-            // setup view fields
-            $fields = array(
-                self::TOKEN . '_link_text' => __( 'Link Text', 'widget-builder' ),
-                self::TOKEN . '_link_url' => __( 'Link URL', 'widget-builder' )
-            );
             $nonce = wp_create_nonce( plugin_basename(__FILE__) );
             // get template hierarchy
@@ -415 +410 @@
 
             // Authenticated
-            $fields = array( self::TOKEN . '_link_text', self::TOKEN . '_link_url', self::TOKEN . '_widget_description', self::TOKEN . '_dashboard', self::TOKEN . '_disable_sidebar' );
+            $fields = array( self::TOKEN . '_link_text', self::TOKEN . '_link_url', self::TOKEN . '_widget_description', self::TOKEN . '_dashboard', self::TOKEN . '_disable_sidebar' );
 
             // Parse fields for add, update, delete
             foreach ( $fields as $f ) {
 
-                ${$f} = strip_tags(trim($_POST[$f]));
-
-                if ( get_post_meta( $post_id, '_' . $f ) == '' ) {
-                    add_post_meta( $post_id, '_' . $f, ${$f}, true );
-                } elseif( ${$f} != get_post_meta( $post_id, '_' . $f, true ) ) {
-                    update_post_meta( $post_id, '_' . $f, ${$f} );
-                } elseif ( ${$f} == '' ) {
-                    delete_post_meta( $post_id, '_' . $f, get_post_meta( $post_id, '_' . $f, true ) );
+                $value = empty($_POST[$f])?FALSE:strip_tags(trim($_POST[$f]));
+                if ( empty($value) ) {
+                    delete_post_meta( $post_id, '_' . $f );
+                } else {
+                    update_post_meta( $post_id, '_' . $f, $value );
                 }
             }

widget-builder/trunk/views/metabox_link.php

@@ -9 +9 @@
     die('-1');
 
-$html = '';
+$html = '';
 
-foreach ( $fields as $f => $label ) {
-    $saved_value = get_post_meta( $post_id, '_' . $f, true );
+$html .= '<p>';
+$html .= sprintf('<label for="%s">%s</label><br />', self::TOKEN.'_link_text', __( 'Link Text', 'widget-builder' ));
+$html .= sprintf('<input type="text" id="%s" name="%s" value="%s" size="32" />', self::TOKEN.'_link_text', self::TOKEN.'_link_text', esc_attr(get_post_meta($post_id, '_'.self::TOKEN.'_link_text', TRUE)));
+$html .= '</p>';
 
-    // verify nonce setup
-    $html .= ($html != "") ? '<br /><br />' : '<input type="hidden" name="' . self::TOKEN . '_nonce" id="' . self::TOKEN . '_noonce" value="' . $nonce . '" />';
+$html .= '<p>';
+$html .= sprintf('<label for="%s">%s</label><br />', self::TOKEN.'_link_url', __( 'Link URL', 'widget-builder' ));
+$html .= sprintf('<input type="text" id="%s" name="%s" value="%s" size="32" />', self::TOKEN.'_link_url', self::TOKEN.'_link_url', esc_attr(get_post_meta($post_id, '_'.self::TOKEN.'_link_url', TRUE)));
+$html .= '</p>';
 
-    $html .= '<label for="' . $f . '">' . $label . '</label>';
-    $html .= '<input type="text" id="' . $f . '" name="' . $f . '" value="' . $saved_value . '" size="32" />';
-
-}
+$html .= '<p>';
+$html .= sprintf('<label for="%s">%s</label><br />', self::TOKEN.'_link_target', __( 'Link Target', 'widget-builder' ));
+$html .= sprintf('<select name="%s" id="%s">', self::TOKEN.'_link_target', self::TOKEN.'_link_target');
+$target = get_post_meta($post_id, '_'.self::TOKEN.'_link_target', TRUE);
+$html .= sprintf('<option value="">%s</option>', __('Open in current window', 'widget-builder'));
+$html .= sprintf('<option value="_blank" %s>%s</option>', selected($target, '_blank', FALSE), __('Open in new window', 'widget-builder'));
+$html .= '</select>';
+$html .= '</p>';
 
 echo $html;

widget-builder/trunk/views/widget.php

@@ -10 +10 @@
 
 // build html
+
 $widget = $before_widget;
 $widget .= ( !empty( $title ) && $instance['hide_widget_title'] == 'show' ) ? $before_title . $title . $after_title : '';
 if ( !empty( $image ) ) {
-    $widget .= ( !empty( $link_url ) ) ? '<a href="' . $link_url . '" target="_blank"><img src="' . $image[0] . '" /></a>' : '<img src="' . $image[0] . '" />'; 
+    $widget .= ( !empty( $link_url ) ) ? '<a href="' . $link_url . '" 
 }
 $widget .= $content;
-$widget .= ( !empty( $link_url ) ) ? '<a href="' . $link_url . '" target="_blank">' . $link_text . '</a>' : '';
+$widget .= ( !empty( $link_url ) ) ? '<a href="' . $link_url . '" >' . $link_text . '</a>' : '';
 $widget .= $after_widget;