-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added list of false positiitives #3999
base: main
Are you sure you want to change the base?
Conversation
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +551 B View Changes
|
src/languages/cpp.js
Outdated
/(?!char)/, | ||
/(?!double)/, | ||
/(?!float)/, | ||
/(?!bool)/, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these types really working properly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we build the exclude list dynamically from our keywords list then instead of repeating ourselves? |
Sure |
Build Size ReportChanges to minified artifacts in 7 files changedTotal change +136 B View Changes
|
Build Size ReportChanges to minified artifacts in 7 files changedTotal change +133 B View Changes
|
…light.js into fix/issue-3980
Build Size ReportChanges to minified artifacts in 7 files changedTotal change +135 B View Changes
|
Issue: (cpp) Keywords followed by parens are treated as built_in
Resolves #3980
Changes
Added list of false positives to
FUNCTION_DISPATCH
The List:
Before:
After:
Checklist
CHANGES.md