-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playground block: A11Y: Add skip links for loaded preview/iFrame #293
Comments
A number of these accessibility issues were closed via "fixes X" commit messages, but it would be better if we leave these open until we tag a new release and @alexstine confirms they are indeed fixed. So I've reopened all of them until then. |
@brandonpayton I won't know until I have a place to test it. |
@alexstine the changes haven't been included in a new plugin release yet. Once there is a new release of the interactive-code-block plugin, will that be sufficient for you to test, or does something else need to be updated in WP.org infrastructure in order to test the new release? (I'm not very familiar with how things are set up for WordPress.org or learn.wordpress.org) |
@brandonpayton Once the plugin is released, let's ping Adam and see if he can sync the new changes to our test page on Learn. Thanks. |
Hi folks. @brandonpayton, once the new version of the plugin has been released in the WordPress.org plugin directory, I usually ask one of the meta team folks to deploy the changes. This usually requires a full deployment of the entire .org network, so depending on what else needs to get done, this can happen in a day or over a few days. We have a testing issue in the Learn.WordPress.org repo that we're using to test these fixes. Would you be able to ping me there once there's a new version in the plugin directory, and then I'll wrangle getting it deployed to Learn? |
Test page: https://learn.wordpress.org/test/wordpress-playground-block-plugin-test-page/
After the Playground iFrame is loaded, there is no way for users to easily skip it. Could we append a "Skip passed iFrame" link or similar? Code structure could look something like this.
Focus could land on that last span with the
tabindex="-1"
set.This will offer users to easily skip the frame since the content within the frame will also have semantics exposed to screen reader users such as headings and landmarks which could be used to skip content in other situations.
The text was updated successfully, but these errors were encountered: