Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Details block: impossible to get out from block, using a keyboard #56263

Closed
talksina opened this issue Nov 17, 2023 · 8 comments · Fixed by #58903
Closed

Details block: impossible to get out from block, using a keyboard #56263

talksina opened this issue Nov 17, 2023 · 8 comments · Fixed by #58903
Assignees
Labels
[Block] Details Affects the Details Block - used to display content which can be shown/hidden [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Testing Needs further testing to be confirmed. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@talksina
Copy link

Description

The block called "details", used in case of inserting a spoiler, has a problem in keyboard navigation: it's impossible to quickly get out from the "detail" block after having written both Summary and Detail parts.
Current result: add Details block, write summary then detail. To get out of the block and add a new one, it's necessary to close the Gutenberg's editing mode switching to navigation mode by pressing Escape key, then press left arrow to Details block, in order to exit it.
Expected result: after writing Summary and Detail -with all content desired for detail-, press "Enter" key twice and it should exit the block, as it does in quotes and lists nested blocks.

Step-by-step reproduction instructions

  1. open an empty post, then add a Details block.
  2. add the Summary. Then the Detail.
    1. press "Enter" key twice, and it will remain in Details without exiting the block.
  3. this applies both with screen reader uses -JAWS, NVDA,VoiceOver-,and without.

Screenshots, screen recording, code snippet

No response

Environment info

Gutenberg latest stable 17.x build, WordPress 6.4.1, theme twenty-twentyfour and applies to all themes

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@talksina talksina added the [Type] Bug An existing feature does not function as intended label Nov 17, 2023
@jordesign jordesign added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Testing Needs further testing to be confirmed. [Block] Details Affects the Details Block - used to display content which can be shown/hidden labels Nov 19, 2023
@talksina
Copy link
Author

still present in latest Gutenberg release

Copy link

Hi,
This issue has gone 30 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Dec 30, 2023
@talksina
Copy link
Author

still present. And no answer to this one...

@github-actions github-actions bot removed the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Dec 31, 2023
Copy link

Hi,
This issue has gone 30 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Jan 31, 2024
@talksina
Copy link
Author

talksina commented Feb 6, 2024

Still present in Gutenberg editor 17.6.x builds.

@github-actions github-actions bot removed the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Feb 7, 2024
@talksina
Copy link
Author

talksina commented Feb 7, 2024

Only work-arounds found to overcome this:

  • switching from editing to navigation mode, pressing Esc; then left arrow till "detail" block closes, and afterwards adding a block manually with "add block" button, then verify the new block is actually out of the "details" tree.
  • adding a new extra-block (empty block) that is, pressing Enter twice on the keyboard so that you have two empty blocks. On the first you create the "details" with summary and content; so, the other empty one, stays out of the Details block and there is no need to have the "edit mode" switched off. But this is not the proper way to work. Hope someone can solve this, it's a persistent issue coming since details block's birth.
@carolinan
Copy link
Contributor

There are over five thousand issues reported in this repository, there is no way for the contributors to work on all, so sometimes it takes time.

@alexstine
Copy link
Contributor

This sounds like a fairly serious accessibility bug. Let me try to look into it soon. As a blind screen reader user, I understand how these issues in Gutenberg can really impact workflows. I am currently traveling on business until February 18th so might not be able to make a PR before then.

Thanks.

@alexstine alexstine self-assigned this Feb 8, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Details Affects the Details Block - used to display content which can be shown/hidden [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Testing Needs further testing to be confirmed. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
4 participants