Search: sync post-meta/taxonomy indexing list into jetpack and document process to expand it

[gibrown]

We have a hard coded list of post meta fields and custom taxonomies that we put into the search index. That list is in class.jetpack-sync-module-search.php on wp.com. We need to:

• sync the list to jetpack and likely refactor it significantly
• use this list to filter what taxonomies are available in the UI
• add the list of post meta keys that can be filtered on (see Search: Index an allowed list of Post Meta for searching #8663)
• document and create examples of how to request adding post-meta/taxonomies to the list (probably on jetpack.com/support/search, but maybe also in the UI).

[gibrown]

Fixing this, may also fix https://github.com/Automattic/jpop-issues/issues/5294 or enable us to fix it.

From the user:

The page builder short cut just read the woocommerce product description

I don't see any data in the DB that contains a product description, so I am guessing that there are some fields we are not syncing and/or not indexing. Probably these: https://github.com/woocommerce/woocommerce/blob/7701d4b57cb20dc89e25bb7bf2ff872d85f4c535/includes/abstracts/abstract-wc-product.php#L62

In theory we are indexing description already, but maybe not short_description

[bluefuton]

@gibrown is this needed for the first release of Jetpack Search for Woo? What's the impact of leaving it out?

[gibrown]

What's the impact of leaving it out?

I don't know. We appear to mostly sync everything correctly, but I suspect there could be some hidden bugs which would result in the displayed data or sorting being wrong. We haven't seen it so far, but I suspect our test sites would need to be more complicated to see them. I think it could also cause bugs we could fix with a minor indexing change to need a full release.

But... I have the changes from the PR review done that will close this. I just need to retest it a bit and do one more round of reviews. I'm hoping I can start a final review tomorrow or Friday.