Changeset 57929

Timestamp:

04/04/2024 07:28:21 PM (3 months ago)

Author:

jorbin

Message:

Upload: Fallback to PclZip to validate ZIP file uploads.

ZipArchive can fail to validate ZIP files correctly and report valid files as invalid. This introduces a fallback to PclZip to check validity of files if ZipArchive fails them.

This introduces the new function wp_zip_file_is_valid() to validate archives.

Follow up to [57388].

Reviewed by jorbin.
Merges [57537] to the 6.4 branch.

Props audunmb, azaozz, britner, cdevroe, colorful-tones, costdev, courane01, endymion00, feastdesignco, halounsbury, jeffpaul, johnbillion, jorbin, jsandtro, karinclimber, kevincoleman, koesper, maartenbelmans, mathewemoore, melcarthus, mujuonly, nerdpressteam, olegfuture, otto42, peterwilsoncc, room34, sayful, schutzsmith, stephencronin, svitlana41319, swissspidy, tnolte, tobiasbg, vikram6, welaunchio.
Fixes #60398.

Location:

branches/6.4

Files:

• . (modified) (view diffs)
• src/wp-admin/includes/class-file-upload-upgrader.php (modified) (view diffs)
• src/wp-admin/includes/file.php (modified) (view diffs)
• tests/phpunit/data/filesystem/_source-license (copied) (copied from trunk/tests/phpunit/data/filesystem/_source-license) (view diffs)
• tests/phpunit/data/filesystem/archive-comment.zip (copied) (copied from trunk/tests/phpunit/data/filesystem/archive-comment.zip) (view diffs)
• tests/phpunit/data/filesystem/archive-cp866.zip (copied) (copied from trunk/tests/phpunit/data/filesystem/archive-cp866.zip) (view diffs)
• tests/phpunit/data/filesystem/archive-directory-entry.zip (copied) (copied from trunk/tests/phpunit/data/filesystem/archive-directory-entry.zip) (view diffs)
• tests/phpunit/data/filesystem/archive-encrypted.zip (copied) (copied from trunk/tests/phpunit/data/filesystem/archive-encrypted.zip) (view diffs)
• tests/phpunit/data/filesystem/archive-flags-set.zip (copied) (copied from trunk/tests/phpunit/data/filesystem/archive-flags-set.zip) (view diffs)
• tests/phpunit/data/filesystem/archive-gnome.zip (copied) (copied from trunk/tests/phpunit/data/filesystem/archive-gnome.zip) (view diffs)
• tests/phpunit/data/filesystem/archive-invalid-ext.md (copied) (copied from trunk/tests/phpunit/data/filesystem/archive-invalid-ext.md) (view diffs)
• tests/phpunit/data/filesystem/archive-invalid.zip (copied) (copied from trunk/tests/phpunit/data/filesystem/archive-invalid.zip) (view diffs)
• tests/phpunit/data/filesystem/archive-large.zip (copied) (copied from trunk/tests/phpunit/data/filesystem/archive-large.zip) (view diffs)
• tests/phpunit/data/filesystem/archive-macos.zip (copied) (copied from trunk/tests/phpunit/data/filesystem/archive-macos.zip) (view diffs)
• tests/phpunit/data/filesystem/archive-ubuntu-nautilus.zip (copied) (copied from trunk/tests/phpunit/data/filesystem/archive-ubuntu-nautilus.zip) (view diffs)
• tests/phpunit/data/filesystem/archive-uncompressed.zip (copied) (copied from trunk/tests/phpunit/data/filesystem/archive-uncompressed.zip) (view diffs)
• tests/phpunit/data/filesystem/archive.crx (copied) (copied from trunk/tests/phpunit/data/filesystem/archive.crx) (view diffs)
• tests/phpunit/tests/filesystem/wpZipFileIsValid.php (copied) (copied from trunk/tests/phpunit/tests/filesystem/wpZipFileIsValid.php) (view diffs)