Changeset 56747

Timestamp:

09/29/2023 05:11:21 PM (10 months ago)

Author:

spacedmonkey

Message:

Comments: Improve WP_Comment_Query count query performance by setting 'order by' to 'none'.

In cases where WP_Comment_Query or get_comments is employed with the 'count' parameter set to true, specify 'order by' as 'none'. Since these queries serve solely to determine the count of comments matching specific query parameters, the 'order by' clause becomes redundant and places unnecessary strain on the database server, resulting in slower query execution. Given that count queries are executed on every admin request to retrieve comment counts, this change enhances the performance of the wp-admin interface.

Props guss77, davidbaumwald, SergeyBiryukov, westonruter, peterwilsoncc, foliovision, hareesh-pillai, spacedmonkey.
Fixes #58368

Location:

trunk

Files:

• src/wp-admin/includes/class-wp-comments-list-table.php (modified) (3 diffs)
• src/wp-admin/includes/meta-boxes.php (modified) (1 diff)
• src/wp-includes/comment.php (modified) (2 diffs)
• src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php (modified) (2 diffs)
• tests/phpunit/tests/comment/query.php (modified) (4 diffs)

trunk/src/wp-admin/includes/class-wp-comments-list-table.php

@@ -178 +178 @@
                 $args,
                 array(
-                    'count'  => true,
-                    'offset' => 0,
-                    'number' => 0,
+                    'count'   => true,
+                    'offset'  => 0,
+                    'number'  => 0,
+                    'orderby' => 'none',
                 )
             )
@@ -299 +300 @@
                         'user_id' => $current_user_id,
                         'count'   => true,
+
                     )
                 );
@@ -519 +521 @@
                 if ( get_comments(
                     array(
-                        'number' => 1,
-                        'type'   => $type,
+                        'count'   => true,
+                        'orderby' => 'none',
+                        'type'    => $type,
                     )
                 ) ) {

trunk/src/wp-admin/includes/meta-boxes.php

@@ -902 +902 @@
         array(
             'post_id' => $post->ID,
-            'number'  => 1,
             'count'   => true,
+
         )
     );

trunk/src/wp-includes/comment.php

@@ -397 +397 @@
         'count'                     => true,
         'update_comment_meta_cache' => false,
+
     );
     if ( $post_id > 0 ) {
@@ -1115 +1116 @@
             'count'      => true,
             'status'     => 'approve',
+
             'parent'     => 0,
             'date_query' => array(

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php

@@ -296 +296 @@
             unset( $prepared_args['number'], $prepared_args['offset'] );
 
-            $query                  = new WP_Comment_Query();
-            $prepared_args['count'] = true;
+            $query                    = new WP_Comment_Query();
+            $prepared_args['count']   = true;
+            $prepared_args['orderby'] = 'none';
 
             $total_comments = $query->query( $prepared_args );
@@ -1189 +1190 @@
         $comment_children = $comment->get_children(
             array(
-                'number' => 1,
-                'count'  => true,
+                ',
+                ',
             )
         );

trunk/tests/phpunit/tests/comment/query.php

@@ -3092 +3092 @@
         $found = $q->query(
             array(
-                'count' => true,
+                'count'   => true,
+                'orderby' => 'none',
             )
         );
@@ -3130 +3131 @@
             array(
                 'count'      => true,
+
                 'meta_query' => array(
                     array(
@@ -5002 +5004 @@
         $query_1           = $q->query(
             array(
-                'fields' => 'ids',
-                'number' => 3,
-                'order'  => 'ASC',
-                'count'  => true,
+                'fields' => 'ids',
+                'number' => 3,
+                'order',
+                'count'  => true,
             )
         );
@@ -5012 +5014 @@
         $query_2 = $q->query(
             array(
-                'fields' => 'ids',
-                'number' => 3,
-                'order'  => 'ASC',
-                'count'  => true,
+                'fields' => 'ids',
+                'number' => 3,
+                'order',
+                'count'  => true,
             )
         );