Changeset 55598

Timestamp:

03/28/2023 02:20:33 PM (16 months ago)

Author:

hellofromTonya

Message:

Date/Time: Revert [55054].

This changeset introduced a regression for partial-hour timezones such as +05:30 UTC which is India and Sri Lanka. How? These timezones are in float. The change made in [55054] type casted them to integer which dropped the decimal for the partial-hour, making the time inaccurate. For example, +05:30 UTC (India and Sri Lanka)'s 'gmt_offset' is 5.5, but with the changeset, it was changed to 5.

Reverting the changeset restores the original state of current_time() and thus resolves the regression.

Props reputeinfosystems, Rarst, hellofromTonya, desrosj, audrasjb, sergeybiryukov, costdev, priethor, francina, nekojonez, codingchicken, cbringmann.
See #57035.
Fixes #57998.

File:

• trunk/src/wp-includes/functions.php (modified) (1 diff)

trunk/src/wp-includes/functions.php

@@ -74 +74 @@
     // Don't use non-GMT timestamp, unless you know the difference and really need to.
     if ( 'timestamp' === $type || 'U' === $type ) {
-        return $gmt ? time() : time() + ( (int) get_option( 'gmt_offset' ) * HOUR_IN_SECONDS );
+        return $gmt ? time() : time() + ( get_option( 'gmt_offset' ) * HOUR_IN_SECONDS );
     }