Changeset 44196

Timestamp:

12/14/2018 09:23:52 PM (6 years ago)

Author:

desrosj

Message:

Twenty Nineteen: Fixes and improvements.

This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core.

• Fix the gallery caption link color. ​https://github.com/WordPress/twentynineteen/pull/687
• Remove left padding from pullquote blocks. ​https://github.com/WordPress/twentynineteen/pull/690
• Print skip-link-focus-fix inline instead of enqueueing as blocking script. ​https://github.com/WordPress/twentynineteen/pull/47
• Fix and improve some strings with placeholders. ​https://github.com/WordPress/twentynineteen/pull/217

Props kjellr, allancole, dimadin, westonruter.

See #45424.

Location:

branches/5.0/src/wp-content/themes/twentynineteen

Files:

• classes/class-twentynineteen-walker-comment.php (modified) (2 diffs)
• functions.php (modified) (2 diffs)
• inc/template-tags.php (modified) (3 diffs)
• js/skip-link-focus-fix.js (modified) (1 diff)
• sass/blocks/_blocks.scss (modified) (2 diffs)
• single.php (modified) (1 diff)
• style-rtl.css (modified) (2 diffs)
• style.css (modified) (2 diffs)
• template-parts/post/author-bio.php (modified) (1 diff)

branches/5.0/src/wp-content/themes/twentynineteen/classes/class-twentynineteen-walker-comment.php

@@ -52 +52 @@
                              */
                             if ( twentynineteen_is_comment_by_post_author( $comment ) ) {
-                                /* translators: %s: SVG Icon */
                                 printf( '<span class="post-author-badge" aria-hidden="true">%s</span>', twentynineteen_get_icon_svg( 'check', 24 ) );
                             }
@@ -111 +110 @@
         <?php
     }
-
 }

branches/5.0/src/wp-content/themes/twentynineteen/functions.php

@@ -222 +222 @@
     wp_style_add_data( 'twentynineteen-style', 'rtl', 'replace' );
 
-    wp_enqueue_script( 'twentynineteen-skip-link-focus-fix', get_template_directory_uri() . '/js/skip-link-focus-fix.js', array(), '20151215', true );
-
     if ( has_nav_menu( 'menu-1' ) ) {
         wp_enqueue_script( 'twentynineteen-priority-menu', get_theme_file_uri( '/js/priority-menu.js' ), array(), '1.0', true );
@@ -236 +234 @@
 }
 add_action( 'wp_enqueue_scripts', 'twentynineteen_scripts' );
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
 
 /**

branches/5.0/src/wp-content/themes/twentynineteen/inc/template-tags.php

@@ -41 +41 @@
     function twentynineteen_posted_by() {
         printf(
+
             '<span class="byline">%1$s<span class="screen-reader-text">%2$s</span><span class="author vcard"><a class="url fn n" href="%3$s">%4$s</a></span></span>',
-            /* translators: 1: SVG icon. 2: post author, only visible to screen readers. 3: author link. */
             twentynineteen_get_icon_svg( 'person', 16 ),
             __( 'Posted by', 'twentynineteen' ),
@@ -86 +86 @@
             $categories_list = get_the_category_list( __( ', ', 'twentynineteen' ) );
             if ( $categories_list ) {
-                /* translators: 1: SVG icon. 2: posted in label, only visible to screen readers. 3: list of categories. */
                 printf(
+
                     '<span class="cat-links">%1$s<span class="screen-reader-text">%2$s</span>%3$s</span>',
                     twentynineteen_get_icon_svg( 'archive', 16 ),
@@ -98 +98 @@
             $tags_list = get_the_tag_list( '', __( ', ', 'twentynineteen' ) );
             if ( $tags_list ) {
-                /* translators: 1: SVG icon. 2: posted in label, only visible to screen readers. 3: list of tags. */
                 printf(
+
                     '<span class="tags-links">%1$s<span class="screen-reader-text">%2$s </span>%3$s</span>',
                     twentynineteen_get_icon_svg( 'tag', 16 ),

branches/5.0/src/wp-content/themes/twentynineteen/js/skip-link-focus-fix.js

@@ -3 +3 @@
  *
  * Helps with accessibility for keyboard only users.
+
+
  *
  * Learn more: https://git.io/vWdr2

branches/5.0/src/wp-content/themes/twentynineteen/sass/blocks/_blocks.scss

@@ -325 +325 @@
             margin-bottom: calc(4.33 * #{ $size__spacing-unit});
             margin-right: 0;
+
         }
 
@@ -578 +579 @@
         .blocks-gallery-item:last-child {
             margin-bottom: 16px;
+
+
+
+
         }
     }

branches/5.0/src/wp-content/themes/twentynineteen/single.php

@@ -28 +28 @@
                     the_post_navigation(
                         array(
-                            'prev_text' => _x( '<span class="meta-nav">Published in</span><br/><span class="post-title">%title</span>', 'Parent post link', 'twentynineteen' ),
+                            /* translators: %s: parent post link */
+                            'prev_text' => sprintf( __( '<span class="meta-nav">Published in</span><span class="post-title">%s</span>', 'twentynineteen' ), '%title' ),
                         )
                     );

branches/5.0/src/wp-content/themes/twentynineteen/style-rtl.css

@@ -3766 +3766 @@
   margin-bottom: calc(4.33 * 1rem);
   margin-left: 0;
+
 }
 
@@ -4046 +4047 @@
 .entry .entry-content .wp-block-gallery .blocks-gallery-item:last-child {
   margin-bottom: 16px;
+
+
+
+
 }
 

branches/5.0/src/wp-content/themes/twentynineteen/style.css

@@ -3778 +3778 @@
   margin-bottom: calc(4.33 * 1rem);
   margin-right: 0;
+
 }
 
@@ -4058 +4059 @@
 .entry .entry-content .wp-block-gallery .blocks-gallery-item:last-child {
   margin-bottom: 16px;
+
+
+
+
 }
 

branches/5.0/src/wp-content/themes/twentynineteen/template-parts/post/author-bio.php

@@ -11 +11 @@
 <div class="author-bio">
     <h2 class="author-title">
+
         <span class="author-heading"><?php echo esc_html( sprintf( __( 'Published by %s', 'twentynineteen' ), get_the_author() ) ); ?></span>
     </h2>